Feat: impl QueryFinalityProviderHasPower in consumer chain #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bournezjc
requested review from
gitferry,
lesterli,
SebastianElvis,
parketh,
gusin13 and
bap2pecs
bournezjc
force-pushed
the
bourne/dev-consumer-chain-support
branch
from
15c6e06 to
2b3308e
Compare
SebastianElvis
approved these changes
Aug 28, 2024
Comment on lines
550
to
556
| btcstakingParams, err := cc.bbnClient.QueryClient.BTCStakingParams() | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| covQuorum := btcstakingParams.GetParams().CovenantQuorum | ||
| ud := btcDel.UndelegationResponse |
There was a problem hiding this comment.
Since this never changes and the isDelegationActive function will be called upon every BTC delegation, how about we pass btcstakingParams as an argument to isDelegationActive rather than querying it everytime?
lesterli
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
context in #496
This pr implements the logic of querying voting power in Op.
Test plan